| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
`lstrip` strips left `/` which results in `ISSUER_URLauthorize`
|
Right, this is half of what is needed. We need to urllib.parse.urljoin here... And we can't build using AnyHttpUrl |
Sorry, something went wrong.
|
Hey @hongkunyoo, thank you for setting this up! I also bumped into this issue, great job 🙌 I tested your solution for URLs like http:localhost:8000 (like the one on this GitHub OAuth example) and got http:localhost:8000//authorize. Althought this will work on every modern browser, it's not the ideal solution, so I created this PR inspired on your's that uses built-in python posixpath to fix this for all URL |
Sorry, something went wrong.
|
Closing this PR since better proposal exists: #779 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
lstrip strips left / which results in ISSUER_URLauthorize
Motivation and Context
/.well-known/oauth-authorization-server output is weirld.
It seems lstrip is unnecessary for each OAuth endpoint
How Has This Been Tested?
Check following result:
curl $MY_MCP_SERVER/.well-known/oauth-authorization-server { "issuer": "$MY_ISSUER", "authorization_endpoint": "$MY_ISSUERauthorize", # / is missing between $MY_ISSUER and authorize "token_endpoint": "$MY_ISSUERtoken", "registration_endpoint": "$MY_ISSUERregister", "scopes_supported": [ "openid" ], "response_types_supported": [ "code" ], "grant_types_supported": [ "authorization_code", "refresh_token" ], "token_endpoint_auth_methods_supported": [ "client_secret_post" ], "revocation_endpoint": "$MY_ISSUERrevoke", "revocation_endpoint_auth_methods_supported": [ "client_secret_post" ], "code_challenge_methods_supported": [ "S256" ] }Breaking Changes
No
Types of changes
Checklist
Additional context