FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Session validation error by moldhouse · Pull Request #798 · modelcontextprotocol/python-sdk · GitHub

/ python-sdk Public

Session validation error #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
moldhouse wants to merge 2 commits into from
Conversation 3 Commits 2 Checks 0 Files changed
Closed

Session validation error #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42163b0
test: request with bad method crashes task
moldhouse May 23, 2025
ab9c9ed
fix: catch validation error of bad rpc request
moldhouse May 24, 2025
File filter

Filter by extension

Filter by extension .py  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 0 additions & 1 deletion src/mcp/client/session_group.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ async def __aexit__(
for exit_stack in self._session_exit_stacks.values():
tg.start_soon(exit_stack.aclose)


@property
def sessions(self) -> list[mcp.ClientSession]:
"""Returns the list of sessions being managed."""
Expand Down
42 changes: 25 additions & 17 deletions src/mcp/shared/session.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -351,26 +351,34 @@ async def _receive_loop(self) -> None:
if isinstance(message, Exception):
await self._handle_incoming(message)
elif isinstance(message.message.root, JSONRPCRequest):
validated_request = self._receive_request_type.model_validate(
message.message.root.model_dump(
by_alias=True, mode="json", exclude_none=True
try:
validated_request = self._receive_request_type.model_validate(
message.message.root.model_dump(
by_alias=True, mode="json", exclude_none=True
)
)
responder = RequestResponder(
request_id=message.message.root.id,
request_meta=validated_request.root.params.meta
if validated_request.root.params
else None,
request=validated_request,
session=self,
on_complete=lambda r: self._in_flight.pop(
r.request_id, None
),
)
)
responder = RequestResponder(
request_id=message.message.root.id,
request_meta=validated_request.root.params.meta
if validated_request.root.params
else None,
request=validated_request,
session=self,
on_complete=lambda r: self._in_flight.pop(r.request_id, None),
)

self._in_flight[responder.request_id] = responder
await self._received_request(responder)
self._in_flight[responder.request_id] = responder
await self._received_request(responder)

if not responder._completed: # type: ignore[reportPrivateUsage]
await self._handle_incoming(responder)
if not responder._completed: # type: ignore[reportPrivateUsage]
await self._handle_incoming(responder)
except Exception as e:
logging.warning(

felixweinberger Sep 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

we should send back some feedback about invalid request to the client here (and update the tests to check for that)
f"Failed to validate request: {e}. "
f"Message was: {message.message.root}"
)

elif isinstance(message.message.root, JSONRPCNotification):
try:
Expand Down
42 changes: 42 additions & 0 deletions tests/shared/test_session_handles_error.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
from collections.abc import AsyncGenerator

import pytest
from anyio.streams.memory import MemoryObjectSendStream

from mcp.shared.memory import create_client_server_memory_streams
from mcp.shared.message import SessionMessage
from mcp.shared.session import BaseSession
from mcp.types import ClientNotification, ClientRequest, JSONRPCMessage, JSONRPCRequest


@pytest.fixture
async def client_write() -> (
AsyncGenerator[MemoryObjectSendStream[SessionMessage], None]
):
"""A stream that allows to write to a running session."""
async with create_client_server_memory_streams() as (
(_, client_write),
(server_read, server_write),
):
async with BaseSession(
read_stream=server_read,
write_stream=server_write,
receive_request_type=ClientRequest,
receive_notification_type=ClientNotification,
) as _:
yield client_write


@pytest.mark.anyio
async def test_session_does_not_raise_error_with_bad_input(
client_write: MemoryObjectSendStream[SessionMessage],
):
# Given a running session

# When the client sends a bad request to the session
request = JSONRPCRequest(jsonrpc="2.0", id=1, method="bad_method", params=None)
message = SessionMessage(message=JSONRPCMessage(root=request))
await client_write.send(message)

# Then the session can still be talked to
await client_write.send(message)
Back | FazBrowse Home | New Git URL