normalize string ID to int in server messages for compatibility - #851
Merged
Kludex merged 11 commits intoJun 8, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
added 6 commits
May 30, 2025 16:04
Some non-standard SSE servers may return numeric IDs as strings, even when the original request used an integer. This change ensures that message.root.id is always an integer to maintain consistency and avoid type issues in downstream processing.
Some non-standard SSE servers may return numeric IDs as strings, even when the original request used an integer. This change ensures that message.root.id is always an integer to maintain consistency and avoid type issues in downstream processing.
format code
Some non-standard SSE servers may return numeric IDs as strings, even when the original request used an integer. This change ensures that message.root.id is always an integer to maintain consistency and avoid type issues in downstream processing.
Some non-standard SSE servers may return numeric IDs as strings, even when the original request used an integer. This change ensures that message.root.id is always an integer to maintain consistency and avoid type issues in downstream processing.
format code
Kludex
reviewed
Jun 7, 2025
Comment thread
src/mcp/types.py
| Cursor = str | ||
| Role = Literal["user", "assistant"] | ||
| RequestId = str | int | ||
| RequestId = Annotated[int | str, Field(union_mode="left_to_right")] |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is really the only change that is necessary.
It will try to validate int first, then str.
Sorry, something went wrong.
Kludex
approved these changes
Jun 7, 2025
Kludex
enabled auto-merge (squash)
June 7, 2025 14:50
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some non-standard SSE servers may return numeric IDs as strings, even when the original request used an integer. This change ensures that message.root.id is always an integer to maintain consistency and avoid type issues in downstream processing.
Normalize message.root.id to integer if it is a numeric string returned by non-standard SSE servers.
Motivation and Context
Some SSE servers return numeric IDs as strings, causing mismatches between request and response IDs. This leads to callbacks not being triggered and the client waiting indefinitely. The change improves compatibility and stability by normalizing the ID type.
How Has This Been Tested?
Tested with mock SSE server responses containing string IDs; verified that messages with string numeric IDs are correctly converted to int and processed without errors.
Breaking Changes
No breaking changes. This is a backward-compatible bug fix.
Types of changes
Checklist
Additional context
This fix addresses compatibility issues with SSE servers that do not strictly follow numeric ID typing conventions. It ensures the client logic for callback matching remains reliable.