fix: disambiguate input-required results with metadata - #1103
Merged
DaleSeo merged 1 commit intoAug 3, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
DaleSeo
marked this pull request as ready for review
July 30, 2026 23:39
DaleSeo
force-pushed
the
fix-input-required-meta
branch
from
eb49261 to
889477a
Compare
July 31, 2026 15:10
alexhancock
approved these changes
Aug 3, 2026
This was referenced Aug 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1094.
Motivation and Context
ServerResult is an untagged Serde union, and CallToolResult comes before InputRequiredResult. Since the CallToolResult deserializer accepted _meta without checking resultType, an intermediate result with metadata was incorrectly treated as an empty, completed tool call. As a result, its input requests and request state were dropped.
This PR prevents metadata-bearing InputRequiredResult values from being silently deserialized as completed tool results. It preserves legacy tool results that don't include resultType and adds regression coverage for both wire formats.
How Has This Been Tested?
Added coverage
Breaking Changes
None.
Types of changes
Checklist