v2 fix: Update spec types to latest; replace AssertObjectSchema with proper JSON type schemas - #1612
Merged
KKonstantinov merged 5 commits intoMar 5, 2026
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Replace the internal AssertObjectSchema (z.custom<object>) with proper Zod schemas (JSONValueSchema, JSONObjectSchema, JSONArraySchema) that produce correct JSON types, aligning the SDK's inferred types with the spec. This eliminates the need for most FixSpec workarounds in the type compatibility tests. Also syncs spec.types.ts and adds missing SDK types (error codes, ResultResponse types, MetaObject types) to pass spec type checks.
Copy link
Copy Markdown
⚠️ No Changeset foundLatest commit: 35a05f0 Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@modelcontextprotocol/client
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1612
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1612
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/express@1612
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/hono@1612
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/node@1612 commit: 56de257 |
Sorry, something went wrong.
KKonstantinov
marked this pull request as ready for review
March 2, 2026 17:01
felixweinberger
approved these changes
Mar 5, 2026
felixweinberger
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, thanks for updating this straight away and for submitting the SEP in the first place! This looks nice now.
Sorry, something went wrong.
chughtapan
added a commit
to chughtapan/typescript-sdk
that referenced
this pull request
Mar 7, 2026
…tObjectSchema The merge with main brought in modelcontextprotocol#1612 which replaced AssertObjectSchema with JSONObjectSchema, but the extensions fields were not updated. Also fixes spec.types.ts to use JSONObject (matching experimental) for bidirectional type compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the internal AssertObjectSchema (z.custom) with proper Zod schemas (JSONValueSchema, JSONObjectSchema, JSONArraySchema) that produce correct JSON types, aligning the SDK's inferred types with the spec.
Also syncs spec.types.ts and adds missing SDK types (error codes, ResultResponse types, MetaObject types) to pass spec type checks.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context