docs(core): @deprecated elicitationId / ElicitationCompleteNotification* (spec #2891) - #2372
Conversation
Sorry, something went wrong.
⚠️ No Changeset foundLatest commit: 19fc972 Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Sorry, something went wrong.
|
@modelcontextprotocol/client
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@2372
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/codemod@2372
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@2372
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server-legacy@2372
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/express@2372
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/fastify@2372
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/hono@2372
npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/node@2372 commit: 19fc972 |
Sorry, something went wrong.
…deprecated (spec #2891) The neutral schemas keep these (2025-era URL-mode flow still uses them); the 2026-07-28 wire codec already excludes the notification. Per the project rule: neutral schemas never drop, only @deprecated; per-revision strictness lives in the wire/rev*/ forks.
There was a problem hiding this comment.
LGTM — JSDoc-only deprecation tags following the established SEP-2577 / 2025-era deprecation pattern; the earlier changeset and server-method-tag suggestions remain optional follow-ups.
Extended reasoning...Overview
This PR only adds @deprecated JSDoc annotations to ElicitationCompleteNotificationParamsSchema, ElicitationCompleteNotificationSchema, the elicitationId field on ElicitRequestURLParamsSchema (in packages/core/src/types/schemas.ts), and the corresponding ElicitationCompleteNotificationParams / ElicitationCompleteNotification type aliases (in packages/core/src/types/types.ts). No Zod validation logic, runtime behavior, or exports change — the schemas and types are byte-for-byte identical apart from comments.
Security risks
None. The change is documentation-only; it cannot affect parsing, validation, transport behavior, or auth.
Level of scrutiny
Low. This is the textbook 'simple, mechanical' change: it mirrors the dozens of existing @deprecated annotations already in the same files (SEP-2577 logging/sampling/roots stacks, 2025-11-25 task vocabulary), and the deprecation rationale matches the spec change (#2891 removed the elicitation-complete notification in 2026-07-28; the 2026 wire codec already excludes it, per the same-day commit 19fc972 in the repo history). The wording is consistent with the surrounding comment style.
Other factors
The bug hunting system found no bugs. My two prior inline comments (missing changeset for the .d.ts-visible deprecation, and optionally tagging Server.createElicitationCompletionNotifier() in packages/server) are nits explicitly framed as dismissible and don't affect the correctness of this diff — the changeset omission also has direct counter-precedent in the repo (PR #2326 merged a docs-only @deprecated sweep without one). Nothing here requires a design decision or human judgment beyond those optional follow-ups.
Sorry, something went wrong.
Adds @deprecated JSDoc to the neutral-schema entries removed from the spec by #2891. No runtime change; the 2026-07-28 wire codec already excludes the notification.
Types of changes
Checklist