Fix import ordering in client auth - #2442
Conversation
Sorry, something went wrong.
⚠️ No Changeset foundLatest commit: e35c984 Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Sorry, something went wrong.
|
@modelcontextprotocol/client
npm i https://pkg.pr.new/@modelcontextprotocol/client@2442
npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2442
npm i https://pkg.pr.new/@modelcontextprotocol/core@2442
npm i https://pkg.pr.new/@modelcontextprotocol/server@2442
npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2442
npm i https://pkg.pr.new/@modelcontextprotocol/express@2442
npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2442
npm i https://pkg.pr.new/@modelcontextprotocol/hono@2442
npm i https://pkg.pr.new/@modelcontextprotocol/node@2442 commit: e35c984 |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM — trivial two-line import reorder to satisfy simple-import-sort, no behavior change.
Extended reasoning...Overview
The PR touches a single file, packages/client/src/client/auth.ts, and only reorders one named import (stampErrorBrands) within an existing import statement from @modelcontextprotocol/core-internal. The import list previously had stampErrorBrands between checkResourceAllowed and LATEST_PROTOCOL_VERSION; the PR moves it after resourceUrlFromServerUrl, which matches simple-import-sort's ASCII ordering (uppercase identifiers before lowercase). The PR description explains this is a lint fix for an ordering issue introduced by the combination of #2384 and #2422, both of which passed CI individually.
Security risks
None. No logic, control flow, or API surface changes — the same symbols are imported from the same module; only their textual order changes.
Level of scrutiny
Minimal scrutiny is appropriate. This is a purely mechanical, style-only change with zero runtime impact, equivalent to running the lint autofix. The changeset-bot warning about a missing changeset is fine since a lint-only reorder does not warrant a version bump.
Other factors
The bug hunting system found no issues, there are no outstanding reviewer comments, and the change is exactly what the description claims. This fits squarely in the 'simple, mechanical, obvious' approval category.
Sorry, something went wrong.
Lint autofix: stampErrorBrands sits out of order in the client/auth.ts import list. #2384 and #2422 each passed CI individually, but their combination trips simple-import-sort on main — any freshly-branched PR now inherits the warning. Two-line reorder, no behavior change.
Types of changes
Checklist