fix(server): leave SSE connection policy to adapters - #2554
Open
colinaaa wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Remove hop-by-hop Connection headers from Web Standard Streamable HTTP responses so concrete HTTP adapters can advertise their actual connection lifetime.
Copy link
Copy Markdown
🦋 Changeset detectedLatest commit: 81a5558 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@modelcontextprotocol/client
npm i https://pkg.pr.new/@modelcontextprotocol/client@2554
npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2554
npm i https://pkg.pr.new/@modelcontextprotocol/core@2554
npm i https://pkg.pr.new/@modelcontextprotocol/server@2554
npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2554
npm i https://pkg.pr.new/@modelcontextprotocol/express@2554
npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2554
npm i https://pkg.pr.new/@modelcontextprotocol/hono@2554
npm i https://pkg.pr.new/@modelcontextprotocol/node@2554 commit: 81a5558 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2553.
Why
A web-standard Response does not own the underlying connection and cannot know its lifetime. Setting Connection: keep-alive in the transport suppresses concrete HTTP/1.1 servers from advertising their real Keep-Alive: timeout=..., and Connection is forbidden on HTTP/2.
Omitting the header does not disable persistent connections. Node HTTP/1.1 can emit its own matching Connection and Keep-Alive headers, while HTTP/2 and other Fetch adapters remain free to apply their own policy. This adds no Connection: close, retry, or timeout behavior.
Verification
Interaction with #2541
#2541 edits the same three header objects to add SSE heartbeat and anti-buffering behavior. The changes are semantically independent: retain its heartbeat and X-Accel-Buffering changes, while omitting only the hop-by-hop Connection header.