FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: dedupe ResponseTooLargeError + respx rationale, fix httpx2 claim by lesnik512 · Pull Request #105 · modern-python/httpware · GitHub

docs: dedupe ResponseTooLargeError + respx rationale, fix httpx2 claim - #105

Merged
lesnik512 merged 1 commit into
mainfrom
docs-compaction-d1-d2
Jul 13, 2026
Merged

docs: dedupe ResponseTooLargeError + respx rationale, fix httpx2 claim#105
lesnik512 merged 1 commit into
mainfrom
docs-compaction-d1-d2

Conversation

Copy link
Copy Markdown
Member

Summary

Follow-up to #103/#104 — resolves the two duplication findings (D1, D2) from planning/audits/2026-07-13-docs-comments-audit.md, tracked in planning/changes/2026-07-13.09-response-too-large-respx-compaction.md. Also fixes a factual regression surfaced while working D2.

  • D1 — ResponseTooLargeError's behavior was spelled out near-verbatim in docs/errors.md, architecture/errors.md, and architecture/client.md. docs/errors.md keeps the full field-by-field account, architecture/client.md keeps the full mechanism account (both untouched beyond dedup), architecture/errors.md is trimmed to the errors-tree-specific facts plus a cross-reference.
  • D2 — the "why not respx" paragraph was duplicated between docs/testing.md and architecture/testing.md. While researching which side to keep, found that #103's mechanical httpx→httpx2 fix had regressed a claim: it changed "respx patches private internals and breaks across httpx major versions" into a claim about httpx2 specifically. Verified against respx's own README (requires httpx 0.25+, no stated httpx2 support) and its GitHub history (documented breakage on httpx major bumps): the claim is real, but about httpx, not httpx2 — httpx2's own docs mentioning respx reads as inherited copy from its stewardship transfer, not a verified compatibility claim. Corrected and deduped, keeping the full rationale in docs/testing.md.

Test plan

  • uvx --with-requirements docs/requirements.txt mkdocs build --strict — clean
  • just lint-ci — clean
  • just test — 780 passed, 100% coverage
  • just check-planning — OK

ResponseTooLargeError's behavior was spelled out near-verbatim in
docs/errors.md, architecture/errors.md, and architecture/client.md;
architecture/errors.md now cross-references the other two instead of
restating them.

The "why not respx" paragraph was duplicated between docs/testing.md
and architecture/testing.md, and the prior audit-fix pass (#103) had
mechanically changed a "breaks across httpx major versions" claim to
say httpx2 instead. Verified against respx's own README (requires
httpx 0.25+, no stated httpx2 support) and GitHub history: the
breakage claim is real but about httpx, not httpx2. Corrected the
claim and deduped, keeping the full rationale in docs/testing.md.
lesnik512 merged commit 144521b into main Jul 13, 2026
6 checks passed
lesnik512 deleted the docs-compaction-d1-d2 branch July 13, 2026 19:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL