| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
It's the exams phase so I don't have a detailed review, but here are some rought points:
|
Sorry, something went wrong.
|
Thanks @salkinium for the quick review. I'm happy with such short mentoring, Nice to hear the code isn't bullshit and thanks for the feedback.
It pays out to handle the Color in delivery format from minute one. The Endian feature in Rgb565 is not yet completely implemented but I do store it in said format and works as expected. Another optimal solution arised - no more need to adjust endianes. See my latest comments in #666.
Painter manipulates Buffer / Display only via one of drawFast(...) because the memory-mappings of monochrome Buffer / colored Buffer / Display work so differently. I don't wanted a composition-coupling via pointer between Painter and Buffer. For max. speed, Painter needs to be a Base to Buffer / Display with virtual drawFast(...) methods. Before: Buffer/Display-> Painter, Now: Painter->Buffer / Display Advantages
The declarations of LocalPainter / RemotePainter are ugly for now. Working on this... |
Sorry, something went wrong.
|
I'm generally positively impressed by these changes and looking forward to the finished PR, particularly since there are many very cool improvements in here! 😍 However, I've completely lost the overview of this PR and GitHub is struggling to show me the whole diff, due to +6,742 −14,976 changes, so I'm struggling to review it… There are also too many commits for me to click through, so I cannot review commit by commit either. I think we need to split this up a little, are there changes you can pull out into separate PRs that are more independent? There's no time pressure, just want to let you know that I'm willing to review just not really able to. |
Sorry, something went wrong.
|
Quote @salkinium, 30 .Juli 2021 in #660 😜
Also didn't expect such a code explosion - It's much fun, a great learning subject and ongoing story: Let's keep #665 as reference and merge proven pieces step bz step! Here's Nr.1 #690
Yes. I have renamed the ordered list in my opening message: Planned commits -> Planned PRs. |
Sorry, something went wrong.
|
I've created PRs for environmental changes @salkinium so we get the table as clean as possible to concentrate on the real chunks. See section Roadmap in this PRs opening message. |
Sorry, something went wrong.
Closed because PR is way too big. First fragments are in review and you find the rest of the code in my origin feature/rewrite-graphic |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Synopsis of added goods
Roadmap
TODO
Here's a list for follow up rounds.
Rewrite Graphics - Round 2