Add drawBitmap method to ColorGraphicsDisplay interface - #831
Draft
mcbridejc wants to merge 1 commit into
Draft
mcbridejc wants to merge 1 commit into
mcbridejc wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I guess? I don't really have an overview anymore over the graphics API, so I'm delegating this to our expert @TomSaw… |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hey @mcbridejc. I'm sitting on a complete rewrite of the graphic APIs since 2021. See these these dependent PRs:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey want to solicit thoughts on this change, or something like it, @TomSaw, @salkinium.
The ILI9341 driver offers a drawBitmap method, which can take a an Rgb565 bitmap as input, but this is not in the ColorGraphicsDisplay interface, and that's a problem because the ILI9341 has many template arguments so it's awkward to pass a reference to it.
Should we just add this virtual method to ColorGraphicsDisplay?