FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix for build on Windows by mdhvg · Pull Request #108 · monatis/clip.cpp · GitHub

/ clip.cpp Public

Fix for build on Windows - #108

Open
mdhvg wants to merge 1 commit into
monatis:mainfrom
mdhvg:main
ConversationCommits (1)ChecksFiles changed
Open

Fix for build on Windows#108
mdhvg wants to merge 1 commit into
monatis:mainfrom
mdhvg:main

Conversation

mdhvg commented Mar 11, 2025

Copy link
Copy Markdown
  • This PR fixes issues in the code that could've lead to undefined behaviours
    • Variable-Length Arrays (VLAs), though supported by GCC and Clang, not recommended for use
float vec[vec_len];
// vec_len being a variable set at runtime.
  • Also, the pthread for windows conversion macro from ggml-org/ggml is added to clip.cpp to enable multi-threading support on Windows.

recurseml Bot reviewed Mar 11, 2025
View reviewed changes
Comment thread clip.h

recurseml Bot commented Mar 11, 2025

Copy link
Copy Markdown

😱 Found 1 issue. Time to roll up your sleeves! 😱

monatis commented Mar 11, 2025

Copy link
Copy Markdown
Owner

Hi @mdhvg, thanks for raising this PR! I'll review it later today and then merge.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
recurseml[bot] recurseml[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL