Prevent m2sh from crashing when it's given too many arguments - #267
Open
cpick wants to merge 3 commits into
Open
Prevent m2sh from crashing when it's given too many arguments#267cpick wants to merge 3 commits into
cpick wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
added 3 commits
July 25, 2015 00:55
m2sh currently crashes when it's passed too many arguments; add an illustrative test case.
The maximum number of tokens (as opposed to the number of bytes) was used as the length argument to a memcpy() call. In practice this didn't turn out to be an issue since it would require more than 13 or 25 (MAX_TOKENS / sizeof(Token *)) command line arguments to trigger, and even then it would result in observably correct behavior since the memcpy()'s destination was only used in Command_destroy() which would simply leak the un-copied tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m2sh command line parsing failed to check whether it was exceeding its maximum number of tokens.
These changes fix the bug and adds tests to verify the fix.