dirlisting: fix bug when displaying file size in dirlisting - #281
Open
gnoliyil wants to merge 1 commit into
Open
dirlisting: fix bug when displaying file size in dirlisting#281gnoliyil wants to merge 1 commit into
gnoliyil wants to merge 1 commit into
Conversation
* type of file size (len) changed to size_t from int to support file larger than 2G * fix a bug of size unit display
alkino
reviewed
May 28, 2018
Comment thread
plugins/dirlisting/dirlisting.c
|
|
||
| /* Function wrote by Max (Felipe Astroza), thanks! */ | ||
| static char *mk_dirhtml_human_readable_size(char *buf, size_t size, int len) | ||
| static char *mk_dirhtml_human_readable_size(char *buf, size_t size, size_t len) |
Copy link
Copy Markdown
There was a problem hiding this comment.
Maybe rename size to buf_size to avoid this sort of problem.
And len to file_len or file_size (look more english).
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.