flb_libco: Add support to build on Apple Silicon - #340
Conversation
Sorry, something went wrong.
Add a check for posix_memalign in stdlib.h as this wasn't detected on M1 causing a _memalign missing symbol Do not include malloc.h if __APPLE__ is defined
Sorry, something went wrong.
Swap from nested #ifndef to #if/#elif/#else which is more readable. #include <malloc_np.h> on FreeBSD
|
@unrelentingtech |
Sorry, something went wrong.
1. try detecting HAVE_POSIX_MEMALIGN in malloc_np for FreeBSD 2. Use if/elif/else for the defines in aarch64.c
|
Yes, that does work. Instead of using platform ifdefs though, maybe provide different defines like HAVE_POSIX_MEMALIGN_IN_STDLIB, HAVE_POSIX_MEMALIGN_IN_PTHREAD_NP from CMake and use them? |
Sorry, something went wrong.
|
We can do that. |
Sorry, something went wrong.
…NP which are more clear about what is going on
|
@unrelentingtech fixed here, I'll fix the other pr as well. |
Sorry, something went wrong.
This patch adds support for fluent-bit to build on M1/Apple Silicon Update to reflect the changes in monkey/monkey#340 1. try detecting HAVE_POSIX_MEMALIGN in malloc_np for FreeBSD 2. Use if/elif/else for the defines in aarch64.c Use HAVE_POSIX_MEMALIGN_IN_STDLIB and HAVE_POSIX_MEMALIGN_IN_PTHREAD_NP which are more clear about what is going on Signed-off-by: Allen Reese <areese999@apple.com>
This patch adds support for fluent-bit to build on M1/Apple Silicon This is upstreamed at monkey/monkey#340 Signed-off-by: Allen Reese <areese999@apple.com>
This patch adds support for fluent-bit to build on M1/Apple Silicon Update to reflect the changes in monkey/monkey#340 1. try detecting HAVE_POSIX_MEMALIGN in malloc_np for FreeBSD 2. Use if/elif/else for the defines in aarch64.c Use HAVE_POSIX_MEMALIGN_IN_STDLIB and HAVE_POSIX_MEMALIGN_IN_PTHREAD_NP which are more clear about what is going on Signed-off-by: Allen Reese <areese999@apple.com> Signed-off-by: Eduardo Silva <eduardo@calyptia.com>
Add a check for posix_memalign in stdlib.h as this wasn't detected on M1 causing a _memalign missing symbol
Do not include malloc.h if APPLE is defined