feat(plot): high-contrast orange elevation line on the gradient profile - #95
Merged
mousebrains merged 1 commit intoMay 30, 2026
Merged
feat(plot): high-contrast orange elevation line on the gradient profile#95mousebrains merged 1 commit into
mousebrains merged 1 commit into
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
The gradient profile's elevation line shared the gradient bars' blue hue (--c-elev was a near-twin of --c-link), so it blended into the bars wherever they overlapped — worst over the tall full-opacity "significant" bars. Recolor the line to a warm orange that contrasts with the blue bars in both themes, and nudge the stroke 1.6 -> 2 for presence: --c-elev light #1565c0 -> #e65100 --c-elev dark #a9d0f5 -> #ffa726 CSS-only (src/kayak/web/static/style.css); no PHP/SVG change. The right-axis elevation tick labels also key off --c-elev, so they recolor to match for free. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Owner
Author
Code Review — #95 feat(plot): high-contrast orange elevation line on the gradient profileVerdict: ✅ Approve. Clean, correctly scoped, and the right fix for a real legibility problem. CSS-only, one variable, zero functional surface. Verified
Worth noting (positive)Blue ↔ orange is also one of the better colorblind-safe pairings (deuteranopia/protanopia separate it cleanly, unlike a red/green choice), so this improves accessibility, not just aesthetics. #e65100 on the white surface clears WCAG 1.4.11 non-text contrast (~3.7:1 ≥ 3:1). Notes
🤖 Reviewed with Claude Code |
Sorry, something went wrong.
mousebrains
added a commit
that referenced
this pull request
May 31, 2026
* docs: round-6 deep project review (graded B+, ▲ from B−) Sixth deep project review of the entire tracked repo — 6 cold facet auditors (Python, PHP/security, schema/data, tests/CI, ops, docs) + synthesizer hand-re-verification, judging two bands: (A) did round-5's fixes durably stick, and (B) what did #93–#98 + migrations 0069–0071 + the two direct-to-main commits introduce. The recursive integrity check passes cleanly for the first time in the series: every round-5 fix (R1.1/R1.2/R1.3/R1.5/R2.1/R3.x/R4.x) landed as a committed PR and is still present at HEAD, and every mechanized guard is proven non-vacuous by break-it experiment. New code is clean — no CRIT/HIGH: #93 USACE kcfs→cfs (correct, per-series), migrations 0069/0070/0071 (idempotent, FK-clean, Bridgeport DROP cascade residue-free), #96/#97 multi-state pickers, #95/#98 gradient JS. Two MED findings, both recurrences of round-5 classes closed by documentation not mechanization: (1) two direct-to-main commits, one of which broke CI on main (the {}-is-a-dict bug); (2) a nightly snapshot overrode migration 0067's sort_name for gauge 217 with no migration. Root cause is shared — main accepts un-CI-gated direct pushes from both humans and the snapshot bot. Lever: route everything through a CI gate (branch protection + a self-gating/auto-merging snapshot), a snapshot-column drift guard, and teach seed_gauge_display to preserve migration-pinned sort_names. Two facet over-claims dissolved on hand-re-verification (the USACE temperature-docstring drop is a correct fix; check_reaches DOES range-check vertices via validate_lat_lon). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs: fold external-review corrections into the round-6 review (#99) The PR #99 external verification pass re-confirmed every finding, severity, and the B+ grade against db34ae0 (recommendation: merge), and flagged one inaccurate evidence line plus three off-by-one citations. Corrected: - MED #1: drop the `git branch --contains` "reachable only from main" claim — feature branches later cut from main now contain 9b428bb / 6007c21, so containment no longer distinguishes them. The direct-to- main conclusion stands on the durable evidence (linear f3ed673..HEAD, no merge commit, missing (#NN) suffix). - citations: ci.yml:114→115, SourceUrlTest.php:83-84→84-85, check_reaches.py:212→213. Added an External-review note recording the pass + the one below-LOW item it surfaced (the 0069/0070 header comments' now-stale PENDING_RECONCILIATION wording). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gradient/elevation plot on description.php drew its elevation line in a blue (--c-elev) that was a near-twin of the gradient bars' blue (--c-link), so the line blended into the bars — worst over the tall full-opacity "significant" bars. This recolors the line to a warm orange that contrasts with the blue bars in both light and dark themes.
Change (CSS-only, src/kayak/web/static/style.css)
No PHP/SVG change — the <polyline class="gp-elev"> already carries no inline color (it's themed via the CSS variable), and the right-axis elevation tick labels also key off --c-elev, so they recolor to match for free.
Verification
🤖 Generated with Claude Code