Fix themes on homepage - #7745
Merged
willdurand merged 1 commit intoMar 21, 2019
Merged
willdurand merged 1 commit into
willdurand merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master mozilla/addons-frontend#7745 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 257 257
Lines 7051 7051
Branches 1312 1312
=======================================
Hits 6912 6912
Misses 125 125
Partials 14 14
Continue to review full report at Codecov.
|
Sorry, something went wrong.
kumar303
approved these changes
Mar 21, 2019
kumar303
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This code is so weird. Thanks for the quick fix.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#13060
It turns out that isTheme was more useful than expected 😓
Screenshots
Before:
After: