FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fallback to a default license name when it is null by willdurand · Pull Request #7910 · mozilla/addons-frontend · GitHub

/ addons-frontend Public

Fallback to a default license name when it is null - #7910

Merged
willdurand merged 3 commits into
masterfrom
fix-7909
Apr 18, 2019
ConversationCommits (3)ChecksFiles changed
Merged

Fallback to a default license name when it is null#7910
willdurand merged 3 commits into
masterfrom
fix-7909

Conversation

willdurand commented Apr 18, 2019

Copy link
Copy Markdown
Member

willdurand commented Apr 18, 2019

Copy link
Copy Markdown
Member Author

It looks like the flow type was inaccurate, according to https://addons-server.readthedocs.io/en/latest/topics/api/addons.html#version-detail-object (license.name is nullable). I changed the Flow type in the 3rd commit but Flow did not complain when I reverted the other commits, so even with the right Flow type, we could have missed this issue.

There is another occurrence of license.name that we could change in a separate patch (assuming this one becomes a hotfix).

kumar303 approved these changes Apr 18, 2019
View reviewed changes

kumar303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

r+wc, this looks good.

We should also fix replaceStringsWithJSX() so it handles this case more gracefully. We can do that in a separate issue.

codecov-io commented Apr 18, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7910 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    mozilla/addons-frontend#7910   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         258      258           
  Lines        7151     7151           
  Branches     1323     1324    +1     
=======================================
  Hits         7011     7011           
  Misses        126      126           
  Partials       14       14
Impacted Files Coverage Δ
src/core/reducers/versions.js 100% <ø> (ø) ⬆️
src/amo/components/AddonVersionCard/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4764c6a...83aee3a. Read the comment docs.

willdurand merged commit b37eda0 into master Apr 18, 2019
willdurand deleted the fix-7909 branch April 18, 2019 17:36
willdurand mentioned this pull request May 5, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
kumar303 kumar303 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: text does not appear to be compatible with the provided replacements

3 participants

Back | FazBrowse Home | New Git URL