This repository was archived by the owner on Jun 10, 2026. It is now read-only.
Use ASCII digits in port number parsing - #207
Closed
zopieux wants to merge 1 commit into
Closed
zopieux wants to merge 1 commit into
zopieux wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Tossing this in the v1.5 milestone. I'll look through it next week. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I broke this when I switched to py.test. I fixed the commit in PR #225. Closing this out in favor of that one. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, bleach accepts (linkyfies) the following “URLs”:
That is because the \d modifier of Python unicode regular expressions matches all digits in the Nd block (search for category [Nd] here), and there are many things in there.
This PR replaces \d with [0-9]+ and two test URLs to assert these links are not recognized.
Note: an alternative would be to use the re.ASCII flag but:
Note: funnily enough, GitHub-flavored markdown also linkyfies them! http://foo.com:𝟠𝟘𝟠𝟘/