FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Do not add trailing period when email address is at the end of a sentence by znerol · Pull Request #219 · mozilla/bleach · GitHub

This repository was archived by the owner on Jun 10, 2026. It is now read-only.
  1. mozilla
  2. bleach

Repository navigation

Do not add trailing period when email address is at the end of a sentence - #219

Closed
znerol wants to merge 1 commit into
mozilla:masterfrom
znerol:bug/master/linkify-mail-end-of-sentence
ConversationCommits (1)ChecksFiles changed
Closed

Do not add trailing period when email address is at the end of a sentence#219
znerol wants to merge 1 commit into
mozilla:masterfrom
znerol:bug/master/linkify-mail-end-of-sentence

Conversation

znerol commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

No description provided.

willkg added this to the v1.5 milestone Sep 26, 2016

willkg commented Sep 26, 2016

Copy link
Copy Markdown
Member

I added this to the v1.5 milestone and will work through it next week.

znerol commented Sep 26, 2016

Copy link
Copy Markdown
Contributor Author

What about the failing 2.6 test? Is that related to the changes here?

FlogFr commented Oct 6, 2016

Copy link
Copy Markdown

@znerol : your travis job on py2.6 failed because of flake8 (https://travis-ci.org/mozilla/bleach/jobs/158673872) . This is not related to the changes, but because of the latest version of flake8 which doesn't support py2.6 anymore (https://gitlab.com/pycqa/flake8/issues/187). I open the discussion on a possible solution on my PR (#220 (comment)).

willkg mentioned this pull request Oct 31, 2016
Merged

willkg commented Oct 31, 2016

Copy link
Copy Markdown
Member

I pushed a py.test rewrite and broke the test in this PR. I fixed it in PR #228. I'm going to close this PR for that one.

willkg closed this Oct 31, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.5

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL