fix: Ensured navigator.webdriver != true in launched Chromium - #3553
Conversation
Sorry, something went wrong.
|
@Rob--W -- thanks for the review and the link to the issue, I hadn't realised that this is a known issue. Without --test-type, the message shown by Chromium is rather annoying. I also discovered in my testing that the --remote-debugging-port option does not exhibit the above issue, so a potential solution could be to switch to that instead. Before I start looking into that, are there any reasons you can think of why this solution wouldn't work or wouldn't be desired? |
Sorry, something went wrong.
Even without --test-type set by default, you can start web-ext run with --args=--test-type (or its shorthand) if you'd like.
The --remote-debugging-port option does not allow loading of extensions, see #3388. For this and other alternatives that I considered, see #3388 (comment) |
Sorry, something went wrong.
|
@Rob--W -- I removed the --test-type flag and added logic to avoid passing --disable-blink-features=AutomationControlled when --enable-blink-features is set with AutomationControlled. I think the right place to mention --test-type would be in the documentation, though I couldn't find the source for that. Not sure why the dependency audit is failing, I didn't change any dependencies. |
Sorry, something went wrong.
Rob--W
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Sorry, something went wrong.
|
@Rob--W -- Thanks for the suggestions, I've committed those now. |
Sorry, something went wrong.
The `--remote-debugging-pipe` flag causes `navigator.webdriver == true` in the launched Chromium instance (provided there is no existing Chromium instance). The `--disable-blink-features=AutomationControlled` flag needs to be passed to prevent this and avoid breaking websites with bot detection features.
Rob--W
left a comment
There was a problem hiding this comment.
Marking as approved to clearly signal that the current shape of the patch looks good to me. In a comment I suggested a way to improve test coverage further, but it is not required for merging.
I'll let another team member do the actual merge and release since I am travelling.
Sorry, something went wrong.
The --remote-debugging-pipe flag causes navigator.webdriver == true in the launched Chromium instance (provided there is no existing Chromium instance). Flags need to be added to prevent this, otherwise many websites with bot detection features are broken.
Fixes #3511