| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
This will keep output cleaner, especially in Android where logging and stdout are mixed.
There was a problem hiding this comment.
I'm puzzled by this formatting; the file itself seems to have proper indentation. Perhaps my local git configuration is to blame...
Sorry, something went wrong.
|
Thanks for your contribution, @benjamin-bader. It looks good to me. @komamitsu, could you check this issue? |
Sorry, something went wrong.
|
@benjamin-bader I noticed that the original e.printStackTrace() is outputted regardless of the log level. But in your change, the stack trace is hidden if the log level is more than FINE. Also, we can output the stack trace of a Throwable using java.util.logging.Logger#log(java.util.logging.Level, java.lang.String, java.lang.Throwable). So maybe we don't need to create org.msgpack.util.Exceptions. Originally, that error message is important and I think we should've outputted it as a higher log level with its stack trace... After all, something like the following code seems better to me. What do you think? } catch (SecurityException e) {
LOG.log(Level.WARNING, "Cannot append a search path of classloader", e);
|
Sorry, something went wrong.
|
@komamitsu Sounds good, thank you for the feedback. I'll fix and update today. |
Sorry, something went wrong.
Additionaly, increase log level of exceptions from FINE to WARNING.
Replacing calls to `Exception#printStackTrace()` with Java logging.
|
@benjamin-bader Sorry for my delay and thanks for your contribution! |
Sorry, something went wrong.
|
Thank you @komamitsu! I had assumed this section of the codebase was obsolete in the upcoming 0.7 release - glad to hear that this may still be useful. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This will keep output cleaner, especially in Android where logging and stdout are mixed.