Mimic SequenceInputStream interface more in SequenceMessageBufferInput - #389
Closed
frsyuki wants to merge 1 commit into
Closed
Mimic SequenceInputStream interface more in SequenceMessageBufferInput#389frsyuki wants to merge 1 commit into
frsyuki wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
well, rather better idea is to move SequenceMessageBufferInput to test package. I think there're little demand for it. How do you think, @xerial? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@frsyuki Just move it to test package. I think there will be no handy way to close a sequence of streams while managing there lifecycle. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I commented as #387 (review) but I changed my mind: I think it's ok to keep SequenceMessageBufferInput as a mimic of SequenceInputStream. We can create another class if necessary.
A reason is that behavior of SequenceMessageBufferInput.close (which is same withSequenceInputStream.close) is surprising, in my opinion. I expect that it closes input sequence without reading buffers. But they consume all of them. However, change of the behavior is also surprising because its behavior becomes inconsistent from SequenceInputStream.