FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix a bug ChannelBufferInput#next blocks until the buffer is filled by komamitsu · Pull Request #428 · msgpack/msgpack-java · GitHub

/ msgpack-java Public

Fix a bug ChannelBufferInput#next blocks until the buffer is filled - #428

Merged
xerial merged 4 commits into
developfrom
fix-issue-426
Jul 11, 2017
ConversationCommits (4)ChecksFiles changed
Merged

Fix a bug ChannelBufferInput#next blocks until the buffer is filled#428
xerial merged 4 commits into
developfrom
fix-issue-426

Conversation

komamitsu commented Jun 22, 2017

Copy link
Copy Markdown
Member

No description provided.

komamitsu mentioned this pull request Jun 22, 2017
Closed
komamitsu changed the title [WIP] Fix a bug ChannelBufferInput#next blocks until the buffer is filled Fix a bug ChannelBufferInput#next blocks until the buffer is filled Jun 24, 2017

komamitsu commented Jun 24, 2017

Copy link
Copy Markdown
Member Author

@xerial Can you take a look at this pull request?

This pull request handles #426. The example code on the issue 426 actually includes the wrong usages (e.g. read/write a byte array without MessagePack header). But the issue itself can be reproduced with a test code this pull request includes.

BTW, the CI test for JDK9 on Travis CI isn't working https://travis-ci.org/msgpack/msgpack-java/jobs/246543240#L662. I have no idea about the error.

komamitsu requested a review from xerial June 24, 2017 13:32

komamitsu commented Jul 4, 2017

Copy link
Copy Markdown
Member Author

@xerial (cc: @frsyuki ) Kindly ping

komamitsu commented Jul 4, 2017

Copy link
Copy Markdown
Member Author

BTW, the CI test for JDK9 on Travis CI isn't working https://travis-ci.org/msgpack/msgpack-java/jobs/246543240#L662. I have no idea about the error.

#429 handled this problem.

xerial commented Jul 11, 2017

Copy link
Copy Markdown
Member

@komamitsu Nice catch. Thanks for the fix. This LGTM

xerial merged commit 81d540d into develop Jul 11, 2017
komamitsu deleted the fix-issue-426 branch July 12, 2017 13:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

xerial Awaiting requested review from xerial

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL