FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

remove "-target:jvm-1.7" from scalacOptions by xuwei-k · Pull Request #456 · msgpack/msgpack-java · GitHub

remove "-target:jvm-1.7" from scalacOptions - #456

Merged
xerial merged 1 commit into
msgpack:developfrom
xuwei-k:patch-1
Feb 9, 2018
Merged

remove "-target:jvm-1.7" from scalacOptions#456
xerial merged 1 commit into
msgpack:developfrom
xuwei-k:patch-1

Conversation

xuwei-k commented Feb 7, 2018

Copy link
Copy Markdown
Contributor

Scala 2.12 does not support "-target:jvm-1.7"

Scala 2.12 does not support "-target:jvm-1.7"

xerial commented Feb 7, 2018

Copy link
Copy Markdown
Member

OK. Then we need to drop java7 support totally in upcoming version.

@komamitsu @frsyuki
Should we bump the version number to 0.9.x before dropping Java7 support?

xuwei-k commented Feb 8, 2018

Copy link
Copy Markdown
Contributor Author

msgpack-java already use sbt 1.x (which does not support Java 7)

xerial commented Feb 8, 2018

Copy link
Copy Markdown
Member

@xuwei-k I'm not sure how sbt handles target:jvm-1.7 option, but msgpack-core-0.8.14.jar still built for JVM7 (class version 0.51):

javap -cp . -v "org.msgpack.core.MessagePack" | grep version                                                                     [11:24:44 Feb 07 2018]
  minor version: 0
  major version: 51

xuwei-k commented Feb 9, 2018
edited
Loading

Copy link
Copy Markdown
Contributor Author

but msgpack-core-0.8.14.jar still built for JVM7 (class version 0.51):

Yes, sbt 1.x can generate JVM7 byte code from Java sources. but sbt 1.x and Scala 2.12 compiler does not run on JVM 7.
This pull request changes scalacOptions not javacOptions. scalacOptions is different from javacOptions.
This change has no effect (just suppress warnings) because Scala 2.12 compiler says follows when set -target:jvm-1.7

[warn] -target is deprecated: -target:jvm-1.7 is deprecated, forcing use of jvm-1.8

xerial commented Feb 9, 2018

Copy link
Copy Markdown
Member

@xuwei-k Thanks for making it clear. I got confused scalacOptions and javacOptions.

xerial merged commit 33ce348 into msgpack:develop Feb 9, 2018

xerial commented Feb 9, 2018

Copy link
Copy Markdown
Member

Merged.

xuwei-k deleted the patch-1 branch February 9, 2018 20:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL