FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add MessagePacker.clear() method to clear position by isopov · Pull Request #459 · msgpack/msgpack-java · GitHub

/ msgpack-java Public

add MessagePacker.clear() method to clear position #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xerial merged 1 commit into from
Feb 12, 2018
Conversation 1 Commits 1 Checks 0 Files changed
Merged

add MessagePacker.clear() method to clear position #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .java  (3) .scala  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
5 changes: 2 additions & 3 deletions msgpack-core/src/main/java/org/msgpack/core/MessageBufferPacker.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,10 @@ private ArrayBufferOutput getArrayBufferOut()
return (ArrayBufferOutput) out;
}

/**
* Clears the written data.
*/
@Override
public void clear()
{
super.clear();
getArrayBufferOut().clear();
}

Expand Down
8 changes: 8 additions & 0 deletions msgpack-core/src/main/java/org/msgpack/core/MessagePacker.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,14 @@ public long getTotalWrittenBytes()
return totalFlushBytes + position;
}

/**
* Clears the written data.
*/
public void clear()
{
position = 0;
}

/**
* Flushes internal buffer to the underlying output.
* <p>
Expand Down
4 changes: 2 additions & 2 deletions msgpack-core/src/main/java/org/msgpack/core/buffer/ArrayBufferOutput.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
public class ArrayBufferOutput
implements MessageBufferOutput
{
private List<MessageBuffer> list;
private final List<MessageBuffer> list;
private final int bufferSize;
private MessageBuffer lastBuffer;
private int bufferSize;

public ArrayBufferOutput()
{
Expand Down
15 changes: 15 additions & 0 deletions msgpack-core/src/test/scala/org/msgpack/core/MessageBufferPackerTest.scala
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package org.msgpack.core

import java.io.ByteArrayOutputStream
import java.util.Arrays

import org.msgpack.value.ValueFactory._

Expand All @@ -32,5 +33,19 @@ class MessageBufferPackerTest extends MessagePackSpec {

packer1.toByteArray shouldBe stream.toByteArray
}

"clear unflushed" in {
val packer = MessagePack.newDefaultBufferPacker
packer.packInt(1);
packer.clear();
packer.packInt(2);

packer.toByteArray shouldBe Array(2)
val buffer = packer.toBufferList().get(0)
buffer.toByteArray() shouldBe Array(2)
val array = Arrays.copyOf(buffer.sliceAsByteBuffer().array(), buffer.size())
array shouldBe Array(2)
}

}
}
Back | FazBrowse Home | New Git URL