FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support JDK17 by xerial · Pull Request #660 · msgpack/msgpack-java · GitHub

Support JDK17 - #660

Merged
xerial merged 4 commits into
developfrom
jdk17-support
Jun 28, 2022
Merged

Support JDK17#660
xerial merged 4 commits into
developfrom
jdk17-support

Conversation

xerial commented Jun 28, 2022
edited
Loading

Copy link
Copy Markdown
Member

To use JDK17 + DirectByteBuffer, we need to set two JVM options:

--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED

This PR adds:

  • CI for JDK17
  • Add a workaround even if these JVM options are not set.
  • Add a warning message when DirectByteBuffer is used in JDK17 without setting these JVM options

Related approaches:

Fixes #600

xerial marked this pull request as ready for review June 28, 2022 09:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not working in 17 JDK

1 participant


Back | FazBrowse Home | New Git URL