Add module name to the package manifest attributes - #986
Open
thatcomputerguy0101 wants to merge 2 commits into
Open
Add module name to the package manifest attributes#986thatcomputerguy0101 wants to merge 2 commits into
thatcomputerguy0101 wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
(PS: I'm not very familiar with sbt, so there may be a better way to do this.) |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Actually, I failed to test my final revision of this properly, so this doesn't work right now. I think it is fixed now. |
Sorry, something went wrong.
thatcomputerguy0101
marked this pull request as draft
May 27, 2026 02:52
`-` is not a vaild character for module names
thatcomputerguy0101
marked this pull request as ready for review
May 27, 2026 03:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried pulling msgpack-core in through Maven, and I noticed that the module name was being parsed from the jar file name as msgpack.core instead of org.msgpack.core. This change adds the module name defined in the sbt config to the package manifest attributes so that Maven autodetects the correct name.