fix build with PHP 8.6: unserialize_callback_func is a zend_string - #185
fix build with PHP 8.6: unserialize_callback_func is a zend_string#185andypost wants to merge 1 commit into
Conversation
Sorry, something went wrong.
php-src commit c82acefe470 converted the PG(unserialize_callback_func) global from char* to zend_string*, so msgpack_unserialize_class() no longer compiles against PHP 8.6. Mirror what ext/standard/var_unserializer.re does in 8.6: an empty ini value is a non-NULL zero-length string and must still be treated as no callback, and the name is duplicated rather than refcounted since the ini string may be persistent.
|
⚠️ Please install the Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #185 +/- ##
=======================================
Coverage 68.51% 68.51%
=======================================
Files 7 7
Lines 1350 1350
Branches 247 247
=======================================
Hits 925 925
Misses 310 310
Partials 115 115 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
remicollet
left a comment
There was a problem hiding this comment.
LGTM, tested with 8.6.0beta1
Sorry, something went wrong.
|
LGTM as well, tested with 8.6.0beta1 on Windows (VS18) |
Sorry, something went wrong.
php-src commit php/php-src@c82acefe470 converted the PG(unserialize_callback_func) global from char* to zend_string*, so msgpack_unserialize_class() no longer compiles against PHP 8.6.
Mirror what ext/standard/var_unserializer.re does in 8.6: an empty ini value is a non-NULL zero-length string and must still be treated as no callback, and the name is duplicated rather than refcounted since the ini string may be persistent.