FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add type stubs. by hoefling · Pull Request #404 · msgpack/msgpack-python · GitHub

/ msgpack-python Public

Add type stubs. - #404

Closed
hoefling wants to merge 5 commits into
msgpack:masterfrom
hoefling:type-stubs
ConversationCommits (5)ChecksFiles changed
Closed

Add type stubs.#404
hoefling wants to merge 5 commits into
msgpack:masterfrom
hoefling:type-stubs

Conversation

hoefling commented Feb 7, 2020

Copy link
Copy Markdown

This PR adds PEP 561 compatibility to msgpack.

I keep the type stubs from this PR for development with msgpack. The idea is to make them available to everyone by adding them to the distribution. There are no changes to the msgpack code itself, the stub is completely separated from the real code.

If you are against adding type stubs, I'd still be grateful for a review that would improve the stub quality - maybe you have a good advice on how to deal with the remaining Any types.

hoefling requested a review from methane February 7, 2020 23:17

codecov-io commented Feb 7, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #404 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
- Coverage   88.06%   87.94%   -0.12%     
==========================================
  Files           5        5              
  Lines         846      846              
==========================================
- Hits          745      744       -1     
- Misses        101      102       +1
Impacted Files Coverage Δ
msgpack/fallback.py 88.81% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2849f55...c7f6c8b. Read the comment docs.

add type stub for the msgpack package
24d01f8 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
add py.typed marker for PEP 561 compatibility
8b9e871 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
include type stubs in the distribution
2bba914 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
move the unpacker type var inside the unpacker class to ensure clean …
547beb6 
…a mypy run

Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
updated according to signature changes in 1.0
c7f6c8b 
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
methane mentioned this pull request Jan 27, 2021
Open
methane changed the title Add PEP 561 compatibility Add type stubs. Jan 27, 2021

methane commented Jan 27, 2021

Copy link
Copy Markdown
Member

I'm sorry, but I am not an expert of typing and I can not maintain it.
I don't want to merge I can not maintain. So I don't merge this pull request anytime soon.

I will drop Python 2 support completely in next major version (in 2021 or 2022). I will reconsider this after it.

hoefling commented Jan 27, 2021

Copy link
Copy Markdown
Author

@methane no worries, I see that someone has created a stubs-only package recently: https://github.com/sbdchd/msgpack-types. So this is not an issue anymore, thus closing.

hoefling closed this Jan 27, 2021
peasoft mentioned this pull request Jan 2, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

methane Awaiting requested review from methane

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL