Nicer error when packing a datetime without tzinfo - #466
Merged
methane merged 3 commits intoNov 16, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## main #466 +/- ##
==========================================
+ Coverage 87.80% 87.84% +0.03%
==========================================
Files 5 5
Lines 730 732 +2
==========================================
+ Hits 641 643 +2
Misses 89 89
Continue to review full report at Codecov.
|
Sorry, something went wrong.
methane
reviewed
Feb 27, 2021
Comment thread
msgpack/_packer.pyx
Outdated
…time without tzinfo
Copy link
Copy Markdown
Contributor
Author
|
Addressed your comment in this new commit – it now respects the default function. The logic is getting a little twisted, though. If you don't think it's worth it for such a minor convenience, I understand. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to pack a datetime.datetime object with msgpack.packb(dt, datetime=True) where the dt object is missing tzinfo, the library throws the generic error TypeError: can not serialize 'datetime.datetime' object.
That threw me off as I thought the problem related to datetime=True, and didn't realise I was missing tzinfo. This small patch outputs a more specific error message for that edge case.