Repository navigation
Reject a mode change while an object is incomplete - #736
Draft
AbhinavMir wants to merge 1 commit into
Draft
AbhinavMir wants to merge 1 commit into
AbhinavMir wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Unpacker.skip() does not build the objects on the parser stack. So stack[].obj stays uninitialized after an incomplete skip(). A later Unpacker.unpack() writes an array item through that pointer and the process crashes. The reverse order drops the reference that the construct pass took. Record the mode that started the object in unpack_context. unpack_construct() and unpack_skip() now raise ValueError on a change. The parser state stays intact, so the original mode still finishes the object.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The guard preserves parser state and the tests cover both unsafe mode-switch directions.
Pull request overviewPrevents unsafe switching between Unpacker.unpack() and skip() while parsing an incomplete container.
Changes:
- Tracks the active parser construction mode.
- Rejects incompatible mode switches with ValueError.
- Adds regression coverage for both switch directions and state recovery.
| File | Description |
|---|---|
| msgpack/unpack_template.h | Adds mode tracking and validation. |
| test/test_sequnpack.py | Tests rejected mode switches and subsequent completion. |
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#734