The C extension accepts pack_ext_type(1.5, b"A") and silently writes type code 1. It also accepts negative codes reserved by the MessagePack format, including -1 for timestamps. The pure-Python packer and ExtType already reject these inputs.
Validate the code before writing an extension header, matching the fallback's TypeError for non-integers and ValueError outside 0–127. Tests cover both autoreset modes, unchanged buffered output after a rejected call, subsequent valid packing, and the two valid boundaries.
Validation on macOS arm64, CPython 3.12:
The new tests fail on the unmodified C extension: 14 failed, 6 passed.
C extension full suite: 165 passed, 1 skipped.
Pure-Python full suite: 162 passed, 4 skipped.
Ruff lint and format checks, and git diff --check, pass.
The existing thread_unsafe marker warning is also present on the unmodified base. Other platforms and free-threaded Python are left to CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C extension accepts pack_ext_type(1.5, b"A") and silently writes type code 1. It also accepts negative codes reserved by the MessagePack format, including -1 for timestamps. The pure-Python packer and ExtType already reject these inputs.
Validate the code before writing an extension header, matching the fallback's TypeError for non-integers and ValueError outside 0–127. Tests cover both autoreset modes, unchanged buffered output after a rejected call, subsequent valid packing, and the two valid boundaries.
Validation on macOS arm64, CPython 3.12:
The existing thread_unsafe marker warning is also present on the unmodified base. Other platforms and free-threaded Python are left to CI.