The fallback sizes its unpackb limits with len(packed) and checks incoming feeds with len(view). For a multidimensional memoryview, that is the first dimension rather than the byte count. A six-byte message reshaped to (2, 3) fails to unpack with a spurious length error, while feeding it can exceed max_buffer_size without raising BufferFull. A zero-dimensional view raises TypeError on Python 3.12.
Normalize input to a contiguous, one-dimensional byte view before computing lengths. Contiguous input is cast without copying; non-contiguous input uses the byte copy already needed by feed. Decoding remains unchanged. Tests cover several shapes, non-contiguous multidimensional input, scalar views, exact-fit feeds, and preserving the stream after an oversized feed is rejected.
Validation on macOS arm64, CPython 3.12:
All six new cases fail on the unmodified fallback and pass on the unmodified C extension.
After the fix: fallback full suite 148 passed, 4 skipped; C extension full suite 151 passed, 1 skipped.
PyPy 3.11: 138 passed, 5 skipped with test/test_except.py excluded. That unchanged module cannot be collected because this PyPy build does not provide _tracemalloc.
Ruff lint and format checks, and git diff --check, pass.
The existing thread_unsafe marker warning also occurs on the base. Other platforms have not been tested locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback sizes its unpackb limits with len(packed) and checks incoming feeds with len(view). For a multidimensional memoryview, that is the first dimension rather than the byte count. A six-byte message reshaped to (2, 3) fails to unpack with a spurious length error, while feeding it can exceed max_buffer_size without raising BufferFull. A zero-dimensional view raises TypeError on Python 3.12.
Normalize input to a contiguous, one-dimensional byte view before computing lengths. Contiguous input is cast without copying; non-contiguous input uses the byte copy already needed by feed. Decoding remains unchanged. Tests cover several shapes, non-contiguous multidimensional input, scalar views, exact-fit feeds, and preserving the stream after an oversized feed is rejected.
Validation on macOS arm64, CPython 3.12:
The existing thread_unsafe marker warning also occurs on the base. Other platforms have not been tested locally.