make it work when there's a dot in the attribute selector - #30
Merged
wscherphof merged 1 commit intoJan 8, 2014
Merged
wscherphof merged 1 commit into
wscherphof merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hi Wouter, Is there any update on this feature? Thanks, |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Sorry, missed the email while on holiday. Will look into it. |
Sorry, something went wrong.
wscherphof
added a commit
that referenced
this pull request
Jan 8, 2014
make it work when there's a dot in the attribute selector
wscherphof
pushed a commit
that referenced
this pull request
Jan 9, 2014
This was referenced Jan 9, 2014
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Wouter,
Thank you for making this htmlparser. But I got a issue when using attribute selector "[src='aaa.jpg']" to select a![]()
node. It seems that the dot in the jpg file caused it. So I try to work around this issue.
If you think that my code style is bad, please feel free to change the code. But I really want this feature supported in this library.
Thanks,
Rocky