FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix for custom fields for includes (many-to-one direction) by srepmub · Pull Request #104 · mts-ai/FastAPI-JSONAPI · GitHub

/ FastAPI-JSONAPI Public

fix for custom fields for includes (many-to-one direction) - #104

Open
srepmub wants to merge 1 commit into
mts-ai:mainfrom
srepmub:include_custom_fields_other_direction
ConversationCommits (1)ChecksFiles changed
Open

fix for custom fields for includes (many-to-one direction)#104
srepmub wants to merge 1 commit into
mts-ai:mainfrom
srepmub:include_custom_fields_other_direction

Conversation

srepmub commented May 20, 2025

Copy link
Copy Markdown

by passing missing include_fields parameter.

fixes issue #101 for me.

m-antonov commented May 21, 2025

Copy link
Copy Markdown
Collaborator

@srepmub thank you for your PR. Please fix the formatting and order of the 'included' in the tests. After that, the changes can be merged into the main branch.

srepmub force-pushed the include_custom_fields_other_direction branch from 863bcef to 8979ba8 Compare May 22, 2025 13:56

srepmub commented May 22, 2025

Copy link
Copy Markdown
Author

not entirely sure what you mean, but how about this..? (user1 and user2 are already in the right order though it seems?)

srepmub force-pushed the include_custom_fields_other_direction branch 2 times, most recently from 837d582 to 39855bd Compare May 23, 2025 13:19

srepmub commented May 23, 2025

Copy link
Copy Markdown
Author

fix a formatting issue.

srepmub force-pushed the include_custom_fields_other_direction branch from 39855bd to ad7bc3a Compare May 26, 2025 08:41

srepmub commented May 26, 2025

Copy link
Copy Markdown
Author

not sure why 'black' insists on putting certain things on a single line, but not similar code elsewhere. another attempt :P

codecov Bot commented May 30, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (a1a4fc5) to head (ad7bc3a).

Additional details and impacted files 

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files          44       44           
  Lines        2408     2408           
  Branches      279      279           
=======================================
  Hits         2202     2202           
  Misses        143      143           
  Partials       63       63
Flag Coverage Δ
unittests 91.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
fastapi_jsonapi/views/view_base.py 93.05% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

srepmub commented Jun 26, 2025

Copy link
Copy Markdown
Author

okay now 'ruff' fails.. will try to fix

fix for custom fields for includes (many-to-one direction)
16e7cf3 
by passing missing include_fields parameter.
srepmub force-pushed the include_custom_fields_other_direction branch from ad7bc3a to 16e7cf3 Compare June 26, 2025 09:04

srepmub commented Jun 26, 2025

Copy link
Copy Markdown
Author

sorry for the delay. hope everything passes now.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL