fix: compute totalPages from unpaginated count query - #106
Open
temrjan wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
The objects_count query reused the same SELECT that already had LIMIT/OFFSET applied, so count() always returned at most page_size rows, making totalPages always 1 regardless of actual row count. Build a separate count query with only filters and joins (no pagination) so that totalPages reflects the true number of pages. Closes mts-ai#103 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #103 — totalPages always returns 1 regardless of actual row count when using page[size] pagination.
Root cause: get_collection() in orm.py builds a query with LIMIT/OFFSET (pagination), then passes the same query to count(). Since count() wraps the query as a subquery, the LIMIT caps the row count to at most page_size, so totalPages = ceil(page_size / page_size) = 1.
Fix: Build a separate count query with only filters and joins (no size/number pagination params). This ensures count() returns the total number of matching rows across all pages.
Test plan
🤖 Generated with Claude Code