Hi, as we briefly discussed in #289, I think that it could be beneficial to the repository to have two things

• Static Analysis of potential issues with the shellscripts. Shellcheck provides some awesome stuff, as you can see in their gallery of bad code such as; catching mistakes with conditionals, poor quoting, and heaps of others. My favourite is the common 'catastropic rm' (rm -rf "$STEAMROOT/"* which would delete /* in the event of an undefined variable). IMO ShellCheck is essential for all shell scripts as it can really save you from a footgun.
• Auto formatting with shfmt. This adds the ability to quickly auto format all the shell files in the repository to follow a common standard. This would be helpful for me particularly, as I would be able to ensure I don't have minor whitespace differences between my fork and upstream.

I have included two things

• ./fmt.sh which provides some simple utilities for formatting, checking and auto application

• Two Github Actions workflows

  • Shellcheck: that will alert you on PRs to new shellcheck warnings introduced, and add code scanning results to your security dashboard. See here for an example..
  • shfmt: this will comment on new PRs with shfmt errors. Please note, you will have to fix all of them on main... or it will complain quite a lot on every PR. I haven't included one that scans main.

  Please note, there is still a bunch of shellcheck issues I did not autofix, mostly because I would like to know if these are welcome changes before I spend time resolving them :)