FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

unbound module by ilyam8 · Pull Request #287 · netdata/go.d.plugin · GitHub

This repository was archived by the owner on Mar 27, 2024. It is now read-only.
/ go.d.plugin Public archive

unbound module - #287

Merged
ilyam8 merged 39 commits into
netdata:masterfrom
ilyam8:unbound
Nov 21, 2019
Merged

unbound module#287
ilyam8 merged 39 commits into
netdata:masterfrom
ilyam8:unbound

Conversation

ilyam8 commented Nov 14, 2019

Copy link
Copy Markdown
Member

codecov-io commented Nov 14, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #287 into master will increase coverage by 0.58%.
The diff coverage is 89.33%.

ilyam8 changed the title [wip] unbound module unbound module Nov 19, 2019

joelhans left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I noticed a few things. Nothing too major!

Comment thread modules/unbound/README.md Outdated
Comment thread modules/unbound/README.md Outdated
Comment thread modules/unbound/README.md Outdated
Comment thread modules/unbound/README.md
Comment thread modules/unbound/README.md Outdated
Comment thread modules/unbound/README.md Outdated
Comment thread modules/unbound/README.md Outdated
Comment thread modules/unbound/README.md Outdated
Comment thread modules/unbound/README.md Outdated
Comment thread modules/unbound/README.md Outdated

joelhans left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! I know the h2 is a little big, but that will get better on the Learn site, and having the right nesting won't throw linter errors.

ilyam8 merged commit fc8adcd into netdata:master Nov 21, 2019
ilyam8 deleted the unbound branch December 3, 2019 20:14
boxjan pushed a commit to AgoraLab/go.d.plugin that referenced this pull request Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unbound queries data-desired-units

3 participants


Back | FazBrowse Home | New Git URL