fix(rabbitmq): remove "rabbitmq_version" check - #21411
Merged
ilyam8 merged 1 commit intoDec 5, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ilyam8
enabled auto-merge (squash)
December 5, 2025 13:27
stelfrag
approved these changes
Dec 5, 2025
Merged
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Dec 6, 2025
(cherry picked from commit b921c2e)
Ferroin
pushed a commit
that referenced
this pull request
Dec 15, 2025
(cherry picked from commit b921c2e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Older versions have only rabbit_version, current versions have rabbitmq_version and rabbit_version. We don't really need this check.
Test Plan
Additional Information
For users: How does this change affect me?Summary by cubic
Removed the rabbitmq_version check in the RabbitMQ collector to avoid errors with older brokers that only provide rabbit_version. This improves compatibility across versions without changing metrics collection.
Written for commit 34f54a4. Summary will update automatically on new commits.