fix(go.d): avoid blocking all jobs when stopping a slow job - #21448
Merged
ilyam8 merged 1 commit intoDec 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a mutex deadlock issue in the job manager where calling job.Stop() while holding the runningJobs mutex could block all job operations if a job was stuck in runOnce().
Key Changes:
- Modified startRunningJob to call stopRunningJob before acquiring the mutex, preventing the lock from being held during the blocking stop operation
- Refactored stopRunningJob to remove the job from the map and explicitly release the mutex before calling the blocking Stop() method
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
ilyam8
enabled auto-merge (squash)
December 11, 2025 12:40
stelfrag
approved these changes
Dec 11, 2025
Merged
Ferroin
pushed a commit
that referenced
this pull request
Dec 15, 2025
(cherry picked from commit 510f134)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manager previously called job.Stop() while holding the runningJobs mutex.
Since Stop() is a blocking call—it waits until the job’s goroutine exits—this created a scenario where a job stuck in runOnce() could hold the mutex for an extended time.
Summary
Test Plan
Additional Information
For users: How does this change affect me?Summary by cubic
Moved job Stop() out of the runningJobs mutex to avoid blocking the manager when stopping slow or stuck jobs. This keeps other jobs responsive during stop operations.
Written for commit eaf7bd4. Summary will update automatically on new commits.