Summary

The Pull Request (PR) introduces adjustments to the metrics and standards for the AD files.

Test Plan

1. Check CI and possible typos.

Additional Information

Summary by cubic

Standardizes and fixes Windows AD, ADCS, and ADFS perflib charts so they collect the right counters and use consistent names. This prevents bad data and makes the plugin more reliable.

• Bug Fixes

  • Guard against missing counters in AD charts (early return) and initialize chart/dim only once.
  • ADCS: fix retrieval processing chart and labels; use ADCSRequestCryptoSigningTime for signing chart; rename crypto_singing to crypto_signing; remove duplicate callback.
  • ADFS: correct metric keys for OAuth Basic vs Post flows; fix chart IDs/titles for logon certificate and password grant requests; call rrdset_done on the correct federation chart.

• Refactors

  • Unify control flow and naming across perflib-ad.c for consistent chart creation and updates.

Written for commit dc33483. Summary will update automatically on new commits.