fix(edit-config): ignore container variable inherited from /etc/profile - #21505
Merged
ilyam8 merged 2 commits intoDec 27, 2025
Merged
fix(edit-config): ignore container variable inherited from /etc/profile#21505ilyam8 merged 2 commits into
ilyam8 merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the edit-config script fails in LXC containers due to an inherited container environment variable from /etc/profile being mistakenly treated as a command.
Key Changes:
- Preserve caller-provided container variable before sourcing /etc/profile
- Restore the original value after sourcing, or unset it if it wasn't initially set
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
system/edit-config
Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
stelfrag
approved these changes
Dec 27, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jan 9, 2026
…le (netdata#21505) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 17bfcfe)
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jan 9, 2026
…le (netdata#21505) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 17bfcfe)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #21504
Issue:
edit-config sources /etc/profile, which may define a container environment variable (e.g. container=lxc in LXC environments).
If container is not explicitly set by the caller, this inherited value is later treated as a command, causing failures.
Fix:
Preserve the container variable only if it was explicitly set by the caller before sourcing /etc/profile.
Test Plan
Additional Information
For users: How does this change affect me?Summary by cubic
Prevent edit-config from using a container value inherited from /etc/profile unless the caller set it. This avoids failures where inherited values (e.g., container=lxc) are treated as commands.
Written for commit bdae96f. Summary will update automatically on new commits.