FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(json): validate json_object before processing in json_walk function by stelfrag · Pull Request #22309 · netdata/netdata · GitHub

/ netdata Public

fix(json): validate json_object before processing in json_walk function - #22309

Merged
stelfrag merged 1 commit into
netdata:masterfrom
stelfrag:fix_json_parsing
Jun 9, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fix(json): validate json_object before processing in json_walk function#22309
stelfrag merged 1 commit into
netdata:masterfrom
stelfrag:fix_json_parsing

Conversation

stelfrag commented Apr 28, 2026 •
edited by cubic-dev-ai Bot
Loading

Copy link
Copy Markdown
Collaborator
Summary
  • Prevent crash on an invalid health.silencers.json file eg with []

Summary by cubic

Add input validation to json_walk (JSON-C path) so it only processes JSON objects. This prevents a crash when health.silencers.json is an array (e.g., []) or otherwise invalid.

  • Bug Fixes
    • Return early if t is NULL or not json_type_object.
    • Zero-initialize JSON_ENTRY to avoid undefined reads.

Written for commit f4968f9. Summary will update on new commits. Review in cubic

sonarqubecloud Bot commented Apr 28, 2026

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

stelfrag marked this pull request as ready for review April 28, 2026 19:42
stelfrag requested a review from thiagoftsm as a code owner April 28, 2026 19:42
Copilot AI review requested due to automatic review settings April 28, 2026 19:42
stelfrag requested a review from vkalintiris as a code owner April 28, 2026 19:42
stelfrag marked this pull request as draft April 28, 2026 19:43
cubic-dev-ai Bot reviewed Apr 28, 2026
View reviewed changes

cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copilot AI reviewed Apr 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR prevents crashes in the JSON-C json_walk path by validating the input json_object before iterating and by avoiding undefined reads from an uninitialized JSON_ENTRY.

Changes:

  • Return early from json_walk when t is NULL or not a JSON object.
  • Zero-initialize JSON_ENTRY before use.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

stelfrag requested a review from Copilot April 28, 2026 20:05
Copilot AI reviewed Apr 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/libnetdata/json/json.c
stelfrag marked this pull request as ready for review April 29, 2026 07:17
stelfrag merged commit 06934c9 into netdata:master Jun 9, 2026
166 checks passed
stelfrag deleted the fix_json_parsing branch June 9, 2026 10:20
stelfrag mentioned this pull request Jun 22, 2026
Merged
Ferroin pushed a commit that referenced this pull request Jul 15, 2026
fix(json): validate json_object before processing in json_walk functi…
0c0d645 
…on (#22309)

(cherry picked from commit 06934c9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments
ilyam8 ilyam8 approved these changes
thiagoftsm Awaiting requested review from thiagoftsm thiagoftsm is a code owner
vkalintiris Awaiting requested review from vkalintiris vkalintiris is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL