Fix based on Coverity and Sonar audits (part 4) - #22332
Merged
stelfrag merged 2 commits intoMay 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Coverity CID 503493 (DEADCODE): in send_curl_request(), the failure path of curl_slist_append() called curl_slist_free_all() through `if(headers)` -- but `headers` is initialized to NULL on entry and only assigned after the append succeeds. The condition can never be true and the free is unreachable. Drop the dead block. The remaining cleanup (curl_easy_cleanup, can_retry=false, return false) is unchanged and correct.
Sonar c:S1763: the `default:` case of the WndProc switch ended with `return DefWindowProc(...);` followed by `break;`. The break was unreachable. Remove the dead line.
Copy link
Copy Markdown
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
@cubic-dev-ai review this PR |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
@stelfrag I have started the AI code review. It will take a few minutes to complete. |
Sorry, something went wrong.
stelfrag
marked this pull request as ready for review
May 1, 2026 07:23
stelfrag
marked this pull request as draft
May 1, 2026 07:23
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Continues the Coverity/Sonar audit cleanup series by removing two unreachable code paths in the claim UI and claim API request code.
Changes:
- Remove an unreachable break after return DefWindowProc() in the Windows claim UI window procedure.
- Remove an unreachable curl_slist_free_all(headers) in the curl_slist_append() failure path (since headers is still NULL there).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/claim/ui.c | Deletes unreachable break in WndProc() default case. |
| src/claim/claim-with-api.c | Deletes unreachable header-list cleanup on curl_slist_append() failure when headers cannot yet be non-NULL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
stelfrag
marked this pull request as ready for review
May 1, 2026 08:04
ilyam8
approved these changes
May 1, 2026
Merged
Ferroin
pushed a commit
that referenced
this pull request
Jul 15, 2026
* claim: drop unreachable curl_slist cleanup on append failure Coverity CID 503493 (DEADCODE): in send_curl_request(), the failure path of curl_slist_append() called curl_slist_free_all() through `if(headers)` -- but `headers` is initialized to NULL on entry and only assigned after the append succeeds. The condition can never be true and the free is unreachable. Drop the dead block. The remaining cleanup (curl_easy_cleanup, can_retry=false, return false) is unchanged and correct. * claim: drop unreachable break in WndProc default case Sonar c:S1763: the `default:` case of the WndProc switch ended with `return DefWindowProc(...);` followed by `break;`. The break was unreachable. Remove the dead line. --------- Co-authored-by: Costa Tsaousis <costa@netdata.cloud> (cherry picked from commit 7b6fddb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary