Fix based on Coverity and Sonar audits (part 6) - #22334
Merged
stelfrag merged 1 commit intoMay 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Sonar c:S876: chart_by_reason() iterated with `size_t i` and passed `-i` to stream_handshake_error_to_string(STREAM_HANDSHAKE). The unary minus on the unsigned counter wrapped to a huge unsigned value that then narrowed to int through implementation-defined conversion (C99 6.3.1.3). It happens to produce the correct -i on two's-complement platforms but is fragile and unportable. Change the loop variable to `int`. The loop bound STREAM_HANDSHAKE_NEGATIVE_MAX is 40, well within int range, and the b->rd[] array has more than enough entries for the same index. The negation is now well-defined signed arithmetic.
Copy link
Copy Markdown
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
@cubic-dev-ai review this PR |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
@stelfrag I have started the AI code review. It will take a few minutes to complete. |
Sorry, something went wrong.
stelfrag
marked this pull request as ready for review
May 1, 2026 07:24
stelfrag
marked this pull request as draft
May 1, 2026 07:24
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Updates pulse chart generation to avoid unsigned negation issues when mapping handshake error codes to labels, aligning with Coverity/Sonar audit-driven cleanup work.
Changes:
- Switch loop index from size_t to int when iterating STREAM_HANDSHAKE_NEGATIVE_MAX so -i produces valid negative handshake codes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
stelfrag
marked this pull request as ready for review
May 1, 2026 08:01
ilyam8
approved these changes
May 1, 2026
Merged
Ferroin
pushed a commit
that referenced
this pull request
Jul 15, 2026
pulse: use int loop variable when negating to STREAM_HANDSHAKE enum Sonar c:S876: chart_by_reason() iterated with `size_t i` and passed `-i` to stream_handshake_error_to_string(STREAM_HANDSHAKE). The unary minus on the unsigned counter wrapped to a huge unsigned value that then narrowed to int through implementation-defined conversion (C99 6.3.1.3). It happens to produce the correct -i on two's-complement platforms but is fragile and unportable. Change the loop variable to `int`. The loop bound STREAM_HANDSHAKE_NEGATIVE_MAX is 40, well within int range, and the b->rd[] array has more than enough entries for the same index. The negation is now well-defined signed arithmetic. Co-authored-by: Costa Tsaousis <costa@netdata.cloud> (cherry picked from commit 2dbbfd6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary