FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix stack buffer overflow in macOS mach_smi collector by artem · Pull Request #22553 · netdata/netdata · GitHub

/ netdata Public

Fix stack buffer overflow in macOS mach_smi collector - #22553

Merged
ilyam8 merged 1 commit into
netdata:masterfrom
artem:fix-overflow
May 25, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Fix stack buffer overflow in macOS mach_smi collector#22553
ilyam8 merged 1 commit into
netdata:masterfrom
artem:fix-overflow

Conversation

artem commented May 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Summary

Fix stack buffer overflow in macOS mach_smi collector

Fixes #22552

Test Plan
Additional Information
For users: How does this change affect me?

Summary by cubic

Fixed a stack buffer overflow in the macOS mach_smi collector by passing the correct element count to the VM stats APIs. This prevents crashes and memory corruption during RAM/swap/page-fault collection.

  • Bug Fixes
    • Use HOST_VM_INFO64_COUNT and HOST_VM_INFO_COUNT instead of sizeof(...) when calling host_statistics64/host_statistics.

Written for commit 96e162c. Summary will update on new commits. Review in cubic

artem requested a review from thiagoftsm as a code owner May 24, 2026 00:34

CLAassistant commented May 24, 2026 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

CLAassistant commented May 24, 2026

Copy link
Copy Markdown


Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

github-actions Bot added area/collectors Everything related to data collection collectors/macos labels May 24, 2026
cubic-dev-ai Bot reviewed May 24, 2026
View reviewed changes

cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

sonarqubecloud Bot commented May 24, 2026

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ilyam8 requested a review from Copilot May 25, 2026 07:24
Copilot AI reviewed May 25, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Fixes a stack buffer overflow crash in the macOS mach_smi collector by passing the correct element count (Mach _COUNT macros, expressed in mach_msg_type_number_t units of 4 bytes) to host_statistics64/host_statistics, instead of sizeof(...) which overstates the buffer by 4x and triggers the stack canary on return.

Changes:

  • Replace sizeof(vm_statistics64_data_t) with HOST_VM_INFO64_COUNT for the host_statistics64 call.
  • Replace sizeof(vm_statistics_data_t) with HOST_VM_INFO_COUNT for the legacy host_statistics call.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ilyam8 enabled auto-merge (squash) May 25, 2026 08:19
ilyam8 merged commit 64ceb9c into netdata:master May 25, 2026
152 of 158 checks passed

ilyam8 commented May 25, 2026

Copy link
Copy Markdown
Member

@artem, thanks!

stelfrag mentioned this pull request Jun 22, 2026
Merged
ilyam8 mentioned this pull request Jul 9, 2026
Closed
Ferroin pushed a commit that referenced this pull request Jul 15, 2026
Fix stack buffer overflow in macOS mach_smi collector (#22553)
0766a99 
(cherry picked from commit 64ceb9c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments
stelfrag stelfrag approved these changes
thiagoftsm Awaiting requested review from thiagoftsm thiagoftsm is a code owner

Assignees

No one assigned

Labels

area/collectors Everything related to data collection collectors/macos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Stack buffer overflow crash in do_macos_mach_smi on Apple Silicon

5 participants

Back | FazBrowse Home | New Git URL