fix(go.d/fail2ban): move fail2ban socket path into ndsudo - #22745
Merged
ilyam8 merged 1 commit intoJun 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes the Fail2ban socket path used when the Agent runs inside Docker by moving it into ndsudo, so the go.d Fail2ban collector no longer passes the socket path as an argument.
Changes:
- go.d Fail2ban exec: stop passing --socket_path when running in Docker and call the socket-specific ndsudo commands directly.
- ndsudo: hardcode the Docker socket path for the fail2ban-client-*-socket command variants.
- Add a Linux-only unit test to verify the exact ndsudo argument vector for host vs Docker status/jail-status calls.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/go/plugin/go.d/collector/fail2ban/exec.go | Removes per-collector Docker socket path argument passing and relies on socket-specific ndsudo commands. |
| src/go/plugin/go.d/collector/fail2ban/exec_test.go | Adds tests that stub ndsudo to assert the collector calls it with the expected arguments. |
| src/collectors/utils/ndsudo.c | Moves the Docker socket path into ndsudo by hardcoding it into Fail2ban socket command templates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
sequenceDiagram
participant GC as Go Collector (fail2ban)
participant ND as ndsudo
participant FB as fail2ban-client
participant SK as fail2ban.sock (Docker)
participant FS as fail2ban-server
Note over GC,FS: Fail2ban Socket Path Centralized in ndsudo
alt Host Mode
GC->>ND: execute("fail2ban-client-status")
ND->>FB: fail2ban-client status
FB->>FS: Query status
FS-->>FB: Status response
FB-->>ND: stdout
ND-->>GC: []byte
else Docker Mode (isInsideDocker=true)
GC->>ND: execute("fail2ban-client-status-socket")
ND->>SK: -s /host/var/run/fail2ban/fail2ban.sock status
SK->>FB: Read socket
FB->>FS: Query status via socket
FS-->>FB: Status response
FB-->>SK: stdout
SK-->>ND: Socket response
ND-->>GC: []byte
end
alt Host Mode (jail)
GC->>ND: execute("fail2ban-client-status-jail", "--jail", jail)
ND->>FB: fail2ban-client status <jail>
FB->>FS: Query jail status
FS-->>FB: Jail status response
FB-->>ND: stdout
ND-->>GC: []byte
else Docker Mode (isInsideDocker=true, jail)
GC->>ND: execute("fail2ban-client-status-jail-socket", "--jail", jail)
ND->>SK: -s /host/var/run/fail2ban/fail2ban.sock status <jail>
SK->>FB: Read socket
FB->>FS: Query jail status via socket
FS-->>FB: Jail status response
FB-->>SK: stdout
SK-->>ND: Socket response
ND-->>GC: []byte
end
Sorry, something went wrong.
ilyam8
enabled auto-merge (squash)
June 16, 2026 13:33
stelfrag
approved these changes
Jun 16, 2026
thiagoftsm
approved these changes
Jun 16, 2026
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jun 22, 2026
) (cherry picked from commit 6a96484)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Jul 15, 2026
(cherry picked from commit 6a96484)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Additional Information
For users: How does this change affect me?Summary by cubic
Move the Fail2ban Docker socket path into ndsudo and stop passing it from the go.d collector. This centralizes configuration, reduces duplication, and avoids mismatches in containers.
Written for commit b5a0ed5. Summary will update on new commits.