Track and account memory allocation size in replication queries - #22756
Merged
stelfrag merged 1 commit intoJun 18, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
- Added `alloc_size` field to `struct replication_query` to store allocation size. - Modified `replication_buffers_allocated` updates to use `alloc_size` for both increments and decrements. - Introduced an additional buffer deallocation safeguard during request cancellation.
Copy link
Copy Markdown
|
Sorry, something went wrong.
stelfrag
marked this pull request as ready for review
June 18, 2026 07:10
thiagoftsm
approved these changes
Jun 18, 2026
thiagoftsm
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Streaming is working as expected. LGTM!
Sorry, something went wrong.
Merged
Ferroin
pushed a commit
that referenced
this pull request
Jul 15, 2026
- Added `alloc_size` field to `struct replication_query` to store allocation size. - Modified `replication_buffers_allocated` updates to use `alloc_size` for both increments and decrements. - Introduced an additional buffer deallocation safeguard during request cancellation. (cherry picked from commit 996c66c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary by cubic
Make memory accounting for replication queries exact by tracking per-query allocation size and correcting counter updates on free and cancellation. Prevents drift in replication_buffers_allocated.
Written for commit 75fffd1. Summary will update on new commits.