No issues found across 1 file

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

Re-trigger cubic

Pull request overview

This PR fixes FreeBSD vm.stats.* sysctl counter reads in freebsd.plugin by using 64-bit types so they match the kernel’s 64-bit counter storage and avoid size-mismatch failures/inaccurate readings.

Changes:

• Read vm.stats.sys.v_intr, vm.stats.sys.v_soft, vm.stats.sys.v_swtch, and vm.stats.vm.v_forks into uint64_t instead of u_int.
• Preserve existing chart update logic while allowing these counters to be fetched with the correct sysctl value size.

src/collectors/freebsd.plugin/freebsd_sysctl.c:690

• The error message for the v_soft sysctl failure disables the wrong chart name. This function creates the system.soft_intr chart, but the error message currently says system.dev_intr, which is misleading during troubleshooting.

    uint64_t soft_intr_number;

    if (unlikely(GETSYSCTL_SIMPLE("vm.stats.sys.v_soft", mib, soft_intr_number))) {
        collector_error("DISABLED: system.dev_intr chart");
        collector_error("DISABLED: vm.stats.sys.v_soft module");

src/collectors/freebsd.plugin/freebsd_sysctl.c:772

• The module name in this error message doesn't match the sysctl being read. On failure of vm.stats.vm.v_forks, it currently reports vm.stats.sys.v_swtch, which makes logs misleading.

    uint64_t forks_number;

    if (unlikely(GETSYSCTL_SIMPLE("vm.stats.vm.v_forks", mib, forks_number))) {
        collector_error("DISABLED: system.forks chart");
        collector_error("DISABLED: vm.stats.sys.v_swtch module");

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.